Repository navigation
Conversation
G-Rath
marked this pull request as ready for review
September 10, 2026 19:44
G-Rath
requested review from
JacobBriggsAckama,
eoinkelly,
halles,
hmaddocks,
hopkincame,
joshmcarthur,
lukeify and
robotdana
September 10, 2026 19:50
nzlaura
approved these changes
Sep 17, 2026
joshmcarthur
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While @byroot has done great work in ensuring the ecosystem is compatible with
jsonv3, it seems like a few gems still need to catch-up - notably, both Rails and Faraday have not yet released their compatibility fixes.Interestingly only our
devisevariant actually fails, but in an internal app with 100% coverage I only needed to patch Rails & Faraday to have everything seemingly working anddevisedoes not seem to use JSON directly itself.I think overall it's better to play it safe and pin ourselves to JSON v2 at least until Rails has released their patch