e2e: add a egress test on http request to non 80 port - #1054
Open
yufan-su wants to merge 1 commit into
Open
Conversation
haiyanmeng
reviewed
Aug 21, 2026
Collaborator
There was a problem hiding this comment.
This one seems mostly duplicate with internal/e2e/fixtures/egressprobe/egressprobe.yaml.tmpl. Can we reuse it somehow to reduce duplication?
Collaborator
There was a problem hiding this comment.
This file seems mostly duplicated with internal/e2e/suites/sdsmint/sdsmint_test.go funcationality-wise.
Can we refactor it somehow to avoid unnecessary duplication?
2 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds TestActorEgressNonStandardPort to the networking suite: an Actor fetches an in-cluster HTTP origin on :8080 through the egress gateway, and we assert both a 200 and an atenet-egress access-log line carrying authority=:8080 with this Actor's SPIFFE SAN.
Changes
internal/e2e/fixtures/egressprobe/httptarget.yaml.tmpl— a Pod + Service on 8080. Reuses the existing egressprobe binary with --listen=:8080internal/e2e/suites/networking/httptarget_test.go— startHTTPTarget renders the manifest into the suite's namespace, applies it via hack/run-tool.sh ko, waits on readiness, and returns the ClusterIP.internal/e2e/suites/networking/networking_test.go— the test itself, reusing createAndResumeActor, fetchThroughEgressActor and assertEgressGatewayConnect unchanged.Tests pass
#1017