hack/microvm-assets: stage assets to rustfs over IPv6 - #1122
Open
Yuan Gao (ygao-g) wants to merge 1 commit into
Open
hack/microvm-assets: stage assets to rustfs over IPv6#1122Yuan Gao (ygao-g) wants to merge 1 commit into
Yuan Gao (ygao-g) wants to merge 1 commit into
Conversation
On an IPv6-only cluster the rustfs ClusterIP is a v6 literal, so the endpoint came out as http://fd00:10:96::abcd:9000 — not a valid URL — and micro-VM asset staging failed outright. Bracketing alone is not enough: the botocore vendored into aws-cli 2.17.0 has no IPv6 endpoint validator and rejects a bracketed literal too. Bracket the literal when it contains a colon, and bump this script's aws-cli pin. The rustfs-bucket-init Job addresses rustfs by DNS name and is left alone, so no address family pays for a fresh in-cluster image pull.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging the micro-VM assets fails on an IPv6-only cluster. The endpoint is built
from the rustfs ClusterIP, which there is a bare IPv6 literal, and a bare literal
is not a URL. Bracketing alone is not enough: the botocore vendored into aws-cli
2.17 has no IPv6 endpoint validator and rejects the bracketed form outright, so
the image pin moves to 2.31.0 as well. Both changes are no-ops on IPv4.
Verified on an
IP_FAMILY=ipv6kind cluster:hack/run-microvm-demo-kind.shnowcompletes and the
counter-microvmgolden snapshot reaches Ready — a micro-VMguest booting and checkpointing on a v6-only cluster.
Part of #246.
🤖 Generated with Claude Code