e2e: read every page when looking for a resource in a list - #1127
Open
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Open
e2e: read every page when looking for a resource in a list#1127NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Conversation
Lists are name-ordered, so a resource created just now is not necessarily on the first page, and treating that page as the whole list reports it missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1126
TestActorSnapshotLifecyclereportssnapshot %q missing from ListActorSnapshotson a cluster that has been up a while, even though the snapshot exists —GetActorSnapshotsucceeds on it one line earlier.The test called
ListActorSnapshotsonce and treated the first page as the whole list. Lists are name-ordered, so a snapshot created just now lands wherever its name sorts: on the cluster where this reproduced it was 1408th of 1518, against a page size of 1000.createActorreadListActorsthe same way.Both now drain the pages through one generic helper. Nothing about the product changes; the assertion just looks at the whole list it always meant to.
CI does not hit this — every run gets a fresh cluster and the
demoatespace stays well under one page — so the paging path will not be exercised there either. It bites long-lived and shared clusters, and it cost time during the #1050 investigation by looking like a real snapshot loss.Measured on the cluster where it reproduced, and re-run locally after a rebase onto current main: