ategcs: recognize every S3 "not there" as object absence - #1135
Open
Troy Chiu (troychiu) wants to merge 1 commit into
Open
ategcs: recognize every S3 "not there" as object absence#1135Troy Chiu (troychiu) wants to merge 1 commit into
Troy Chiu (troychiu) wants to merge 1 commit into
Conversation
This was referenced Aug 21, 2026
Troy Chiu (troychiu)
force-pushed
the
split/1-s3-object-absence
branch
from
August 22, 2026 00:10
f4a8bc6 to
d4c40e4
Compare
Troy Chiu (troychiu)
force-pushed
the
split/1-s3-object-absence
branch
from
August 22, 2026 00:18
d4c40e4 to
2e53dfc
Compare
Troy Chiu (troychiu)
marked this pull request as ready for review
August 22, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #372
Recognize any HTTP 404 response (including bare 404s and
NoSuchBucket) in addition to typedNoSuchKeyerrors as object absence in the S3 client, mapping them toateerrors.ReasonFailedGetExternalObject. This ensures consistent absence classification across AWS S3 and S3-compatible endpoints (e.g., MinIO, R2, Ceph). HTTP 403 (AccessDenied) remains an unclassified error.AI has assisted with this PR but I have verified all the changes.