test: reject arbitrary-port routing failures - #1144
Open
Flandern (Flandern1211) wants to merge 1 commit into
Open
test: reject arbitrary-port routing failures#1144Flandern (Flandern1211) wants to merge 1 commit into
Flandern (Flandern1211) wants to merge 1 commit into
Conversation
Require the unlisted-port E2E case to receive atunnel's 502 Bad Gateway response so upstream 503/504 failures cannot be reported as a successful port rejection.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I signed the Google CLA and triggered the New Contributors rescan. The cla/google check is currently pending; please let me know if maintainer-side approval or a further rescan is required. |
Contributor
|
We already have https://github.com/agent-substrate/substrate/pull/1103/changes. This PR is duplicate please close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1102
Summary
The arbitrary-port E2E test previously treated every non-200 response as a successful rejection. That allowed upstream routing failures such as HTTP 503 or 504 to pass the test.
Require the expected 502 Bad Gateway response emitted by atunnel instead, so the test only passes when the unlisted actor port is actually rejected by the actor ingress path.
Validation
go test ./internal/e2e/suites/networking -run '^$' -count=1— passed (package compilation)go vet ./internal/e2e/suites/networking— passedgo test ./internal/atunnel -run '^TestServeHTTP' -count=1— passedFull Linux test suite, root-gated tests, and gVisor/microVM E2E — delegated to GitHub Actions because this workstation is Windows without Docker/KinD
Tests pass
Appropriate changes to documentation are included in the PR (no documentation changes are needed for this test-only fix)