Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentContextits own event-loop thread so one blocked chat cannot wedge unrelated chatsRoot cause
Every chat constructed
DeferredTask(thread_name="AgentContext").EventLoopThreadis a singleton by name, so all chats ran on one asyncio loop; one synchronous blocker stopped every chat at once. UI messages were only held in memory before dispatch and chat persistence normally happened at message-loop completion, so a wedge could leave no durable record.This is separate from #1793 / #1794: those address unsafe teardown of shared loop threads; this change removes cross-chat sharing at the
AgentContextboundary.Fixes #1889
Verification
pytest tests/test_agent_context_event_loop_isolation.py tests/test_message_durability.py tests/test_defer_lifecycle.py -q— 7 passedpy_compilepassed for all changed Python filesgit diff --checkpassedAdditional neighboring suites could not collect in the existing local environment because optional
pathspecandcrontabpackages are absent.