Repository navigation
fix(planner): use canonical AIC estimator config [AIC-1770] - #14065
jasonqinzhou wants to merge 2 commits into
Conversation
Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe planner now builds canonical and legacy AIC configurations. Engine creation supports typed canonical SDK inputs, legacy configurations, and regression fallback paths. Unit, integration, and wheel smoke tests cover these paths. ChangesAIC configuration compatibility
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The PR is merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description includes the required Overview, Details, reviewer-start guidance, and Related Issues sections. It explains the migration, compatibility bridge, validation, sequencing, and related Linear issue. It also confirms that no GitHub issue is linked.
Comment |
…-construction Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
| import msgspec | ||
| import aiconfigurator_core | ||
| from aiconfigurator_core.sdk import RustForwardPassPerfModel | ||
| from aiconfigurator_core.sdk import ( |
There was a problem hiding this comment.
The repository still pins aiconfigurator-core==0.11.0.dev20260728, and the new planner bridge explicitly supports that pre-canonical wheel. This smoke script now unconditionally imports the canonical types, so the mocker-extra wheel smoke will fail with ImportError against the pinned release before validating the installed wheels. Keep the smoke test compatible with the supported legacy wheel or update every synchronized AIC dependency pin once the canonical API is published.
🤖 AI Fix
Gate the canonical imports and construction on API availability, using the legacy estimator API for the pinned pre-canonical wheel.
| _DURATION_EXCLUSIVE_MAX_SECONDS = float(1 << 64) | ||
|
|
||
| AicForwardPassPerfModel = aic_sdk.RustForwardPassPerfModel | ||
| # Rolling-release bridge: merge this Dynamo migration before AISimulate PR #13. |
There was a problem hiding this comment.
Condense this migration narrative. Retain only that the legacy branch supports older wheels and that the SDK exports these types lazily; the AISimulate PR reference, release-order explanation, and planned-removal history are transient implementation history.
🤖 AI Fix
Replace these lines with a concise comment describing the older-wheel compatibility requirement and lazy SDK exports.
Overview:
Migrate Dynamo Planner and the wheel smoke contract to AISimulate's canonical forward-pass estimator construction API.
This is the compatibility companion for ai-dynamo/aisimulate#13. It must merge before AISimulate PR 13 is merged or released.
Details:
ForwardPassPerfModelConfigandForwardPassPerfOptionsfor every Planner construction path and callRustForwardPassPerfModel.best_available.from_nativeconstructor to the canonical typed API.Required order:
Validation:
33 passedacross focused Planner unit and native integration tests.Where should the reviewer start?
components/src/dynamo/planner/core/perf_model/engine_query.pycomponents/src/dynamo/planner/core/perf_model/aic_adapter.pytests/wheels/smoke_install.pyRelated Issues
🚫 This PR is NOT linked to a GitHub issue:
Related Linear issue: AIC-1770.
Summary by CodeRabbit
Bug Fixes
Tests