Conversation
Make engine startup validate that persistent KV hooks were actually installed. Fail closed when the requested integration is missing or incomplete instead of starting with non-persistent cache semantics. Signed-off-by: mkhadkevich <mkhadkevich@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verify at worker startup that the requested persistent-KV integration was actually installed for vLLM or SGLang. Incomplete or missing hooks now fail closed instead of silently serving with ordinary process-owned KV.
Why this is needed
Configuration alone is not evidence that cache allocation and recovery hooks are active. A silent partial install would make the endpoint look healthy while providing no crash-surviving KV guarantee.
Validation
Stack
hutm/gms-common-16-v1-persistent-pool.This PR is intentionally draft and stacked on its immediate predecessor.