Skip to content

fix(gms): fence and supervise persistent KV services - #15039

Draft
hutm wants to merge 1 commit into
hutm/gms-hardening-03-tp-reattachfrom
hutm/gms-hardening-04-service-fencing
Draft

hutm wants to merge 1 commit into
hutm/gms-hardening-03-tp-reattachfrom
hutm/gms-hardening-04-service-fencing

Conversation

@hutm

@hutm hutm commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fence stale writer generations across restarts and supervise the persistent KV directory and helper services.

Why this is needed

Route removal and heartbeat loss detect failure but do not validate the metadata generation or guarantee that every recovery helper is healthy.

Validation

  • The cumulative publication tip is byte-identical to the locally validated implementation.
  • Cumulative focused validation: 994 passed, 1 skipped; the later vLLM-focused rerun passed 244 tests.
  • Local TP2 crash tests passed exact-output recovery for vLLM and SGLang; final performance qualification remains tracked in DEP: Production hardening for persistent GMS KV failover #15035.
  • This draft checkpoint still requires normal CI and reviewer validation before merge.

Stack

This PR is intentionally draft and stacked on its immediate predecessor.

Fence stale writers across restarts and supervise the persistent KV helper services so takeover cannot silently proceed with an invalid generation.

Signed-off-by: mkhadkevich <mkhadkevich@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant