Repository navigation
refactor(station): drop try_publish to track aimdb-sync - #14
Merged
Merged
Conversation
aimdb-sync removed SyncProducer::try_set and SyncError::SetTimeout: every built-in buffer overwrites, so try_set duplicated set(). Remove the try_publish_* variants built on it from StationHandle and the C, C++ and Python bindings, and stop describing publish_* as waiting for buffer space. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aimdb-knx-connector no longer depends on embassy-sync or critical-section, so the path-dependency lock was stale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aimdb-sync removed
SyncProducer::try_set,try_set_valueandSyncError::SetTimeout(aimdb-dev/aimdb#288). Every built-in buffer overwrites rather than refusing a write, sotry_setdid the same thing asset(). This PR removes the station APIs that were built on it.Breaking: the station's FFI surface shrinks.
StationHandle::try_publish_temperature/try_publish_humidityws_station_try_publish_temperature/ws_station_try_publish_humidityStation::try_publish_*Station.try_publish_*Callers should switch to
publish_*. It no longer waits for buffer space, so it doesn't block where thetry_form didn't.Also:
publish_*docs no longer say the call blocks or waits for room in the buffer.other_db_failures_stay_runtimenow usesSyncError::GetTimeout, which is classified asRetryjust likeSetTimeoutwas.Test plan
cargo test -p weather-station --features synccargo test -p weather-station-cpp --libcargo clippy -D warningsonweather-station(sync),weather-station-py,weather-station-cppcargo fmt --checkweather-station-cpp/cpp/station.cppsyntax-checks against the trimmed headers🤖 Generated with Claude Code