Repository navigation
feat(cli): distinct exit codes per failure class (#334) - #337
Merged
Merged
Conversation
lxsaah
force-pushed
the
feat/334-cli-exit-codes
branch
from
October 24, 2026 09:57
a9278f2 to
a107544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aimdbused to exit with 1 for every error, so a script couldn't tell an unreachable instance (worth retrying) from a refused request. Every command now uses one exit-code scheme:RecordNotFound,WriteProtected,ServerError,Other)UnsupportedEndpoint,InvalidJsonConnectionFailed,NoInstancesFound,ProtocolMismatch,Io,Jsonjoin's device flow, design 056 §5)Changes
CliError::exit_code()with the constantsEXIT_REJECTED,EXIT_USAGEandEXIT_ENVIRONMENT. The match has no wildcard, so a new variant won't compile until its code is chosen.mainexits withe.exit_code().Changed (breaking)entry: connection errors now exit with 3 instead of 1.Tests
CliErrorvariant maps to its class.tests/exit_codes.rsruns theaimdbbinary: an unreachableunix://socket → 3,--connect bogus://x→ 2, invalid JSON forrecord set --dry-run→ 2, an unknown subcommand → 2. The first three fail whenmainstill exits withexit(1).Verified locally:
cargo test -p aimdb-cliandcargo clippy -p aimdb-cli --all-targets. The fullmake checkis left to CI.Found while doing this, but not changed here:
aimdb-clidoesn't compile with--features yaml. That gets its own PR.Related Issue
Checklist
make check). Left to CI.🤖 Generated with Claude Code
https://claude.ai/code/session_01YPDjQ947yKjLLAq3Xzgu3e