Add missing # type: ignore when using LocalProxy - #6094
Merged
Merged
Conversation
Per 6060080 we need to lie to the type checker because there isn't yet a way of handling proxy objects in type hints. We already do this in every other case, for example: https://github.com/alphagov/notifications-admin/blob/e502b06e0947aef2174c073bdf1b3c8950f799da/app/extensions.py#L21
quis
changed the title
# ignore when using LocalProxy`# ignore when using LocalProxy
quis
changed the title
# ignore when using LocalProxy# type: ignore when using LocalProxy
risicle
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per 6060080 we need to lie to the type checker because there isn't yet a way of handling proxy objects in type hints.
We already do this in every other case, for example:
notifications-admin/app/extensions.py
Line 21 in e502b06