Remove compatibility helpers for Elasticsearch to Opensearch - #3693
Merged
Merged
Conversation
We Do not need compatibility with Elasticsearch 6.x anymore
We Do not need compatibility with Elasticsearch 6.x anymore
We Do not need compatibility with Elasticsearch 6.x anymore
We Do not need compatibility with Elasticsearch 6.x anymore
We Do not need compatibility with Elasticsearch 6.x anymore
We Do not need compatibility with Elasticsearch 6.x anymore
We Do not need compatibility with Elasticsearch 6.x anymore
koetsier
force-pushed
the
remove_compat
branch
from
September 18, 2026 15:23
949d757 to
7c4cacd
Compare
koetsier
marked this pull request as ready for review
September 21, 2026 09:32
This class provided compatibility between Elasticsearch and OpenSearch by normalising the representation of the total number of documents returned. Now that we have upgraded to OpenSearch, it is no longer needed. Update the tests to reflect the removal.
koetsier
force-pushed
the
remove_compat
branch
from
September 21, 2026 09:33
cd4af42 to
4a2e9c9
Compare
koetsier
changed the title
As we have removed the compatibility classes, we can remove this.
hannako
reviewed
Sep 21, 2026
| module ElasticsearchClient | ||
| class << self | ||
| def delete(id:, index_name:, client: Services.elasticsearch) | ||
| client.delete(compatible_params(index: index_name, id: id)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we introduced the ElasticsearchClient class to ensure our code
is compatible with both Elasticsearch version 6.8 and Opensearch
Having completed the upgrade to Opensearch, we can remove this
compatibility code.