Repository navigation
Show approval prompts as cards in the web UI - #118
Merged
Merged
Conversation
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully adds clarification and approval UI functionality. The implementation correctly handles approval prompts, displays choices as clickable buttons, and processes user responses appropriately. The code is well-tested with comprehensive unit tests covering approval reply classification, diff display, and streaming events. No blocking issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
monatis
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Approval prompts (
ask_user, shell and edit approvals) now show as a card in the web UI, with the diff and approve / deny / always / abort buttons. The streamedcompletionevent carries an optionalclarificationfield, so older clients are unaffected.Also fixes two existing bugs that affected every channel:
approvewas always treated as deny, because of theUser reply:prefixabortleft the conversation stuck as busy; it now replies with a short noticeTested with
cargo test, clippy and fmt, and live in the browser against a fake LLM.