Repository navigation
[pull] main from forem:main - #388
Merged
Merged
Conversation
* Fix responsive YouTube embed height The iframe carries width/height attributes as fallback dimensions, but with only `width: 100%` in the inline style the fixed `height` attribute still resolves, so `aspect-ratio` never recalculates the height. In wider containers (observed on organization pages after #23827) this rendered a stretched 2.05:1 player. Adding `height: auto` lets the declared aspect ratio control the height while keeping the attributes as a fallback. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Fix failing specs in liquid_embed_extractor_spec and descript_tag_spec --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
* chore: wire omniauth-mlh 4.2.0 and refresh caches * fix: narrow omniauth-mlh dependency update * chore: vendor omniauth-mlh 4.2.0 gem --------- Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
* feat: require confirmation before cross-account identity attach - differing resolved target raises AccountSwitchConfirmation - ineligible resolution fails closed, attaching to nobody - suspended/spam targets excluded from silent attach paths * chore(auth): trim account switch comments and specs * fix(auth): add missing account_not_eligible translations for ineligibility errors --------- Co-authored-by: jcs <jcs@local> Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )