Repository navigation
[pull] main from forem:main - #395
Merged
Merged
Conversation
Mail sent to a new DEV user before their mlh identity landed was keyed by email, which Customer.io stored as the person's id, leaving an orphan beside the Core-keyed person that nothing ever merges. - Hold Customer.io mail for users without an mlh identity and replay the same mailer call with backoff (~1h cap) until the link lands, then send keyed by the Core uid. Never falls back to email or SMTP. - Stop sending confirmation instructions to users confirmed at creation (OAuth signups): confirmation_required? dropped Devise's !confirmed?. - Data update script merging existing email-keyed orphans into their linked person. Claude-Session: https://claude.ai/code/session_01MprdoWHE671sCWu7kJfTda Entire-Checkpoint: 01M35QSR672XNCZS7AS5YJSBYF
in_batches walks the users primary key, so filtering on created_at alone scanned ~4M older users before finding the first post-rollout one and hit the 2.5s statement timeout. Batch from the first post-rollout id instead. Renamed to a new timestamp so it runs on deploy: DataUpdateWorker only picks up enqueued scripts, and the original failed before sending anything. Claude-Session: https://claude.ai/code/session_01MprdoWHE671sCWu7kJfTda Entire-Checkpoint: 01M35SKSTR4NX3W6V6MKXHZR8T
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )