Repository navigation
[pull] main from forem:main - #399
Merged
Merged
Conversation
) The web and API param whitelists only permitted `video_source_url` when it was present, so a blank/null value sent by the editor's "Remove" button was silently dropped and the cover video stayed on the article. - Permit `video_source_url` when the key is present and blank, so the cover video can be removed. The host whitelist is unchanged. - Extract the whitelist into `Article::LINKED_VIDEO_SOURCE_PATTERNS` / `Article.permitted_video_source_url?` so both controllers share it. - In `generate_video_embed_url`, clear the derived `video` (and the Mux-derived thumbnail) when a previously set source URL is removed, without touching articles whose `video_source_url` was already nil. - Regression specs for the model, web and API update paths. Fixes #23118
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )