Repository navigation
Conversation
swinchen
force-pushed
the
adsp-sc846-no-cgu1-clkinsel
branch
from
October 19, 2026 21:03
a9afa44 to
21389b1
Compare
qasim-ijaz
approved these changes
Oct 20, 2026
sipraga
reviewed
Oct 20, 2026
cdu_init() unconditionally writes CONFIG_CDU0_CGU1_CLKIN to REG_CDU0_CLKINSEL (0x3108F044) to select the CGU1 input clock. The CLKINSEL register is optional in the CDU block and is not implemented on ADSP-SC846. Skip the write on SC846 so the SPL does not access an unimplemented register during early clock initialisation. Fixes: 3285a56 ("arch: sc5xx: Add SC846 DDR init hooks") Signed-off-by: Sam Winchenbach <sam.winchenbach@analog.com>
swinchen
force-pushed
the
adsp-sc846-no-cgu1-clkinsel
branch
from
October 20, 2026 14:16
21389b1 to
b108f75
Compare
swinchen
marked this pull request as ready for review
October 20, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cdu_init() unconditionally writes CONFIG_CDU0_CGU1_CLKIN to REG_CDU0_CLKINSEL (0x3108F044) to select the CGU1 input clock.
The CLKINSEL register is optional in the CDU block and is not implemented on ADSP-SC846.
Skip the write on SC846 so the SPL does not access an unimplemented register during early clock initialisation.
Fixes: 3285a56 ("arch: sc5xx: Add SC846 DDR init hooks")