ci: check out a referenced angr/binaries pull request - #54
Merged
Merged
Conversation
The binaries checkout has no ref, so it always builds against master and a pull request whose test needs a fixture from an open angr/binaries pull request fails here regardless of what its body references. Resolve the ref with the shared angr/ci-settings action and pass it to the existing checkout, which keeps this workflow's own checkout options.
Member
Author
|
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS The failing jobs all stop in That is the expected state while angr/ci-settings#123 is open: this references the action at The workflow file was checked with |
Member
|
Corpus decompilation diffs can be found at angr/dec-snapshots@master...angr/pysoot_54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS
The
angr/binariescheckout carries noref, so this workflow always builds against master. A pull request whose new test loads a fixture from an openangr/binariespull request fails here no matter what its body references, which is the same gapangr/cleclosed in angr/cle#738.This resolves the ref with the shared action from angr/ci-settings and passes it to the existing checkout, so this workflow's own checkout options are untouched.
Blocked on angr/ci-settings#123, which adds the action; this references it at
master.