fix(@angular/cli): revert package.json changes if installation tasks fail during update#33563
Open
clydin wants to merge 2 commits into
Open
fix(@angular/cli): revert package.json changes if installation tasks fail during update#33563clydin wants to merge 2 commits into
clydin wants to merge 2 commits into
Conversation
clydin
force-pushed
the
fix-update-rollback-package-json
branch
from
d16c590 to
c1c68a5
Compare
…fail during update When running the update command, if package manager installation fails (e.g., due to peer dependency conflicts or network issues), the project's package.json is left in an updated state but node_modules is missing or inconsistent. To prevent leaving the workspace in a broken state, backup the original package.json before applying the update plan, and restore it from the backup if the installation tasks throw an error.
clydin
force-pushed
the
fix-update-rollback-package-json
branch
from
c1c68a5 to
a560aa9
Compare
…e managers Other package managers (pnpm, yarn, bun) deterministically reconcile node_modules with the lockfile during installation, making full directory deletion unnecessary and slow. Keep node_modules cleanup only for npm for now.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a backup and restore mechanism for the package.json file during the update process, ensuring it is restored to its original state if the update fails. Additionally, it optimizes the update process by skipping the node_modules cleaning task when the package manager is not npm. There are no review comments, and the changes are well-implemented, so I have no feedback to provide.
clydin
added
target: patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the update command, if package manager installation fails (e.g., due to peer dependency conflicts or network issues), the project's package.json is left in an updated state but node_modules is missing or inconsistent.
To prevent leaving the workspace in a broken state, backup the original package.json before applying the update plan, and restore it from the backup if the installation tasks throw an error.
Closes #22162