Repository navigation
feat(popup): stop syncing when the popup opens - #1213
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bundle sizeThis PR changes what the popup or content scripts load.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The popup no longer starts a Google Drive sync when it opens. It shows the last sync time, any error or sign-in prompt, and syncs only on Sync now / Retry.
The background already syncs on browser start, on coming back after being away, 30s after an edit, and every 30 minutes, so the on-open sync rarely added anything. It cost a Drive request on most opens and could reload the style list mid-click.
SyncStylebot.vue: no sync increated; the spinner always shows for a click-started syncsyncSucceedsStorybook fixture that only answered the on-open syncReview notes: Safari has no idle API, so there it now relies on startup, the 30-minute alarm and the button. A never-synced profile shows just the Sync now button, with no "Syncing…" text.
Testing:
yarn test,yarn lint,yarn typecheck,yarn test:storybook(319 passed).🤖 Generated with Claude Code