Skip to content

feat(popup): stop syncing when the popup opens - #1213

Merged
ankit merged 3 commits into
mainfrom
claude/sync-popup-open-9f6022
Oct 14, 2026
Merged

ankit merged 3 commits into
mainfrom
claude/sync-popup-open-9f6022

Conversation

@ankit

@ankit ankit commented Oct 14, 2026

Copy link
Copy Markdown
Owner

The popup no longer starts a Google Drive sync when it opens. It shows the last sync time, any error or sign-in prompt, and syncs only on Sync now / Retry.

The background already syncs on browser start, on coming back after being away, 30s after an edit, and every 30 minutes, so the on-open sync rarely added anything. It cost a Drive request on most opens and could reload the style list mid-click.

  • SyncStylebot.vue: no sync in created; the spinner always shows for a click-started sync
  • Unit tests and interaction stories drive syncs through the button; dropped the syncSucceeds Storybook fixture that only answered the on-open sync

Review notes: Safari has no idle API, so there it now relies on startup, the 30-minute alarm and the button. A never-synced profile shows just the Sync now button, with no "Syncing…" text.

Testing: yarn test, yarn lint, yarn typecheck, yarn test:storybook (319 passed).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Bundle size

This PR changes what the popup or content scripts load.

Bundle Size Change Gzip Change
Popup 178.3 KB -209 B (-0.1%) 48.8 KB -20 B (-0.0%)
fonts/fonts.css 2.9 KB – 458 B –
popup/index.css 23.3 KB – 5.2 KB –
popup/index.js 152.1 KB -209 B (-0.1%) 43.1 KB -18 B (-0.0%)
Content script (document_start) 89.4 KB – 23.0 KB –
editor/index.js 50.2 KB – 11.8 KB –
inject-css/index.js 36.1 KB – 9.8 KB –
site-bridge/index.js 3.1 KB – 1.4 KB –

ankit and others added 2 commits October 14, 2026 17:44
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ankit
ankit merged commit 0c70078 into main Oct 14, 2026
7 checks passed
@ankit
ankit deleted the claude/sync-popup-open-9f6022 branch October 14, 2026 21:51
@ankit ankit mentioned this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant