Skip to content

fix: build store packages clean and only from the release tag - #1225

Merged
ankit merged 2 commits into
mainfrom
claude/clean-release-builds
Oct 17, 2026
Merged

ankit merged 2 commits into
mainfrom
claude/clean-release-builds

Conversation

@ankit

@ankit ankit commented Oct 17, 2026

Copy link
Copy Markdown
Owner

The 4.0.5 Firefox zip was rejected by AMO ("File is too large to parse"). Webpack 4 never empties its output folder, so Monaco's TypeScript worker (about 7 MB) from an old build was still in firefox-dist/ and dist/ and got zipped, even though the copy rule now leaves it out.

  • Production builds empty their output folder first
  • package:firefox stops if any JS file is over AMO's 4 MB parse limit
  • package:firefox and upload:chrome / upload:edge / upload:firefox refuse to run unless HEAD is the vX.Y.Z tag, so stores only get the merged release commit
  • docs/releases.md and the release skill now say to check out the tag first

Review note: Safari's upload is left out, since TestFlight builds go up from commits that aren't tagged.

Testing: planted stale files and both production builds removed them; the size check flagged a 5 MB file and passed the real build; packaging and upload refused off the tag and passed on a tagged HEAD.

🤖 Generated with Claude Code

ankit and others added 2 commits October 17, 2026 15:19
…es AMO can't parse

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Bundle size

No change to what the popup or content scripts load.

Bundle Size Change Gzip Change
Popup 182.0 KB – 49.2 KB –
fonts/fonts.css 2.9 KB – 458 B –
popup/index.css 23.9 KB – 5.3 KB –
popup/index.js 155.2 KB – 43.5 KB –
Content script (document_start) 90.0 KB – 23.1 KB –
editor/index.js 50.8 KB – 11.9 KB –
inject-css/index.js 36.1 KB – 9.8 KB –
site-bridge/index.js 3.1 KB – 1.4 KB –

@ankit
ankit merged commit 66b6a1c into main Oct 17, 2026
7 checks passed
@ankit
ankit deleted the claude/clean-release-builds branch October 17, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant