Repository navigation
fix: build store packages clean and only from the release tag - #1225
Merged
Merged
Conversation
…es AMO can't parse Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bundle sizeNo change to what the popup or content scripts load.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 4.0.5 Firefox zip was rejected by AMO ("File is too large to parse"). Webpack 4 never empties its output folder, so Monaco's TypeScript worker (about 7 MB) from an old build was still in
firefox-dist/anddist/and got zipped, even though the copy rule now leaves it out.package:firefoxstops if any JS file is over AMO's 4 MB parse limitpackage:firefoxandupload:chrome/upload:edge/upload:firefoxrefuse to run unless HEAD is thevX.Y.Ztag, so stores only get the merged release commitdocs/releases.mdand the release skill now say to check out the tag firstReview note: Safari's upload is left out, since TestFlight builds go up from commits that aren't tagged.
Testing: planted stale files and both production builds removed them; the size check flagged a 5 MB file and passed the real build; packaging and upload refused off the tag and passed on a tagged HEAD.
🤖 Generated with Claude Code