Support a regex for the API's CORS allowed origins - #71778
Draft
pierrejeambrun wants to merge 1 commit into
Draft
Conversation
Deployments whose API clients run on dynamic hostnames — per-branch preview environments, ephemeral subdomains — cannot enumerate every origin ahead of time, and the wildcard is rejected because Airflow's API requires credentialed CORS. FastAPI's CORS middleware already accepts a regex that echoes the matched origin back rather than `*`, which stays compatible with credentialed responses, so expose it as an optional config option. closes: apache#52155
boring-cyborg
Bot
added
area:API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the API's CORS configuration with an optional
access_control_allow_origin_regexoption, matched against the requestOrigin. It's aimed at deployments whose API clients run on dynamic hostnames — per-branch preview environments, ephemeral subdomains — where the exact origins can't be enumerated ahead of time and the wildcard is rejected (Airflow's API requires credentialed CORS).FastAPI's
CORSMiddlewarealready supportsallow_origin_regexand echoes the matched origin back rather than*, so it stays compatible with the credentialed responses the API needs. On a match the exact origin is returned; a regex-only configuration now enables CORS as well.closes: #52155
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines