Add deadline order_by option to Dag runs list API - #71779
Draft
pierrejeambrun wants to merge 1 commit into
Draft
Conversation
Deadline-driven views need to surface the most urgent runs first, which the list endpoints could not express because runs could only be ordered by their own columns and not by the deadlines attached to them.
boring-cyborg
Bot
added
area:API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
deadlineas anorder_byoption for the Dag runs list endpoints (GET /dags/{dag_id}/dagRunsandPOST /dags/~/dagRuns/list), ordering runs by their earliest attached deadline.Revives #60861 (reviewed and approved, but went stale from inactivity).
closes: #51758
Note:
deadlineorders correctly under the default offset pagination and the batch endpoint. Since it resolves to a computed subquery rather than aDagRuncolumn, ordering by it under cursor pagination falls under the existing column-formSortParamlimitation.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines