[hotfix][Persistence] Use the AMS JVM clock for optimizer heartbeats - #4327
Draft
czy006 wants to merge 2 commits into
Draft
[hotfix][Persistence] Use the AMS JVM clock for optimizer heartbeats#4327czy006 wants to merge 2 commits into
czy006 wants to merge 2 commits into
Conversation
…lock optimizer.touch_time was written with two different clocks: inserts used the AMS JVM epoch via Long2TsConverter, heartbeats used the DB's CURRENT_TIMESTAMP. Every consumer compares the value against System.currentTimeMillis() (keeper expiry math, follower sync and the leader-failover baseline), so a DB-AMS clock offset expired live optimizers prematurely (or kept dead ones forever) in distributed deployments. updateTouchTime now takes the JVM timestamp and writes it through Long2TsConverter; touch() passes the just-refreshed optimizer value. Regression test TestOptimizerMapperTouchTime (red with DB clock: stored value off by exactly the injected 123456ms offset). Fix record: docs/fix-records/2026-08-16-fix-18-touch-time-clock-source.md
czy006
force-pushed
the
codex/hotfix-optimizer-heartbeat-clock
branch
from
August 18, 2026 02:16
ae92b60 to
63fe8ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief change log
Pass the AMS JVM time to the optimizer heartbeat mapper instead of relying on the database clock. This makes heartbeat persistence consistent across supported databases.
How was this patch tested?
TestOptimizerMapperTouchTimelocally with JDK 11 before creating this pull request.Documentation