Skip to content

fix(cmake): align minimum version and improve flatcc discovery - #992

Draft
paleolimbot wants to merge 2 commits into
apache:mainfrom
paleolimbot:codex/cmake-flatcc-discovery
Draft

paleolimbot wants to merge 2 commits into
apache:mainfrom
paleolimbot:codex/cmake-flatcc-discovery

Conversation

@paleolimbot

Copy link
Copy Markdown
Member

Follow up #949 by requiring CMake 3.18 for find_library(REQUIRED), guarding CMP0135 by availability, and discovering unsuffixed Debug flatcc runtimes before falling back to Release. Update the library-directory description for shared runtimes.

Add build-time IPC smoke tests covering external static/shared runtimes, static preference, Debug/Release, both directory options, and missing libraries, with cross-platform CI. Package exports remain scoped to #963.

Validated on Linux with CMake 3.18.4 and 4.2.3; confirmed the CMake 3.23 policy failure before and successful configuration after. Formatting checks pass. Windows/macOS validation is delegated to CI.

@codecov-commenter

codecov-commenter commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.52%. Comparing base (55df060) to head (dc5f1b9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   78.59%   78.52%   -0.08%     
==========================================
  Files         106      106              
  Lines       17153    17195      +42     
  Branches     2043     2064      +21     
==========================================
+ Hits        13482    13502      +20     
- Misses       2422     2431       +9     
- Partials     1249     1262      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants