ARTEMIS-6116 Fix tests for windows OS by GChuf · Pull Request #6513 · apache/artemis

GChuf · 2026-06-12T11:17:50Z

Fixes tests on windows.

jbertram · 2026-06-19T13:06:50Z

      producer.applyProperties(mockMessage);

-      assertEquals("Unable to set property: myKey. Did not recognize type: myType. Supported types are: boolean, int, long, byte, short, float, double, string.\n", context.getStderr());
+      assertEquals("Unable to set property: myKey. Did not recognize type: myType. Supported types are: boolean, int, long, byte, short, float, double, string.\n", context.getStderr().replace("\r\n", "\n"));


This seems like a good place to use System.lineSeparator().

Changed to assertEquals("Unable to set property: myKey. Did not recognize type: myType. Supported types are: boolean, int, long, byte, short, float, double, string." + System.lineSeparator()

jbertram · 2026-06-22T18:02:34Z

As far as I can tell, the two JDK8/IBM related commits aren't specific to Windows so they shouldn't be associated with ARTEMIS-6116 either.

jbertram · 2026-06-22T19:13:39Z

+      // Normalize paths to forward slashes
+      String sourceKeyPath = sourceKey.replace("\\", "/");
+      String sourceCertPath = sourceCert.replace("\\", "/");
+
      Files.write(serverPemConfigFile.toPath(), Arrays.asList(new String[]{
-         "source.key=" + sourceKey,
-         "source.cert=" + sourceCert
+         "source.key=" + sourceKeyPath,
+         "source.cert=" + sourceCertPath


Are you sure this is strictly necessary? My testing indicates that it isn't.

Retested - In my case, reverting back to "sourceKey" and "sourceCert" without replacing "\\" results in the following error:

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.528 s -- in org.apache.activemq.cli.test.WebServerCLITest [INFO] Running org.apache.activemq.cli.test.WebServerComponentTest [ERROR] Tests run: 33, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 6.559 s <<< FAILURE! -- in org.apache.activemq.cli.test.WebServerComponentTest [ERROR] org.apache.activemq.cli.test.WebServerComponentTest.testSSLAutoReloadPemConfigSources -- Time elapsed: 0.014 s <<< ERROR! ootAppDataLocalTempjunit-6633549398662602348serverserver-key.pem:Users at org.apache.activemq.artemis.component.WebServerComponent.getStoreFile(WebServerComponent.java:377) at org.apache.activemq.artemis.component.WebServerComponent.addStoreResourceScannerTask(WebServerComponent.java:439) at org.apache.activemq.artemis.component.WebServerComponent.addStoreResourceScannerTask(WebServerComponent.java:459) at org.apache.activemq.artemis.component.WebServerComponent.createServerConnector(WebServerComponent.java:342) at org.apache.activemq.artemis.component.WebServerComponent.start(WebServerComponent.java:203) at org.apache.activemq.cli.test.WebServerComponentTest.startSimpleSecureServer(WebServerComponentTest.java:373) at org.apache.activemq.cli.test.WebServerComponentTest.testSSLAutoReloadPemConfigSources(WebServerComponentTest.java:677) at org.apache.activemq.cli.test.WebServerComponentTest.testSSLAutoReloadPemConfigSources(WebServerComponentTest.java:618) [ERROR] org.apache.activemq.cli.test.WebServerComponentTest.testSSLAutoReloadPemConfigSourcesWithSymbolicLinks -- Time elapsed: 0.016 s <<< ERROR! ootAppDataLocalTempjunit-10694756726840033654storestore-key.pemC:Users at org.apache.activemq.artemis.component.WebServerComponent.getStoreFile(WebServerComponent.java:377) at org.apache.activemq.artemis.component.WebServerComponent.addStoreResourceScannerTask(WebServerComponent.java:439) at org.apache.activemq.artemis.component.WebServerComponent.addStoreResourceScannerTask(WebServerComponent.java:459) at org.apache.activemq.artemis.component.WebServerComponent.createServerConnector(WebServerComponent.java:342) at org.apache.activemq.artemis.component.WebServerComponent.start(WebServerComponent.java:203) at org.apache.activemq.cli.test.WebServerComponentTest.startSimpleSecureServer(WebServerComponentTest.java:373) at org.apache.activemq.cli.test.WebServerComponentTest.testSSLAutoReloadPemConfigSources(WebServerComponentTest.java:677) at org.apache.activemq.cli.test.WebServerComponentTest.testSSLAutoReloadPemConfigSourcesWithSymbolicLinks(WebServerComponentTest.java:623) [INFO] [INFO] Results: [INFO] [ERROR] Errors: ootAppDataLocalTempjunit-6633549398662602348serverserver-key.pemes:618->testSSLAutoReloadPemConfigSources:677->startSimpleSecureServer:373 » IllegalArgument Store file does not exist: C:Users ootAppDataLocalTempjunit-10694756726840033654storestore-key.pemcesWithSymbolicLinks:623->testSSLAutoReloadPemConfigSources:677->startSimpleSecureServer:373 » IllegalArgument Store file does not exist: C:Users [INFO] [ERROR] Tests run: 36, Failures: 0, Errors: 2, Skipped: 0 [INFO] [ERROR]

OK. Could you do something like this instead:

Files.write(serverPemConfigFile.toPath(), Arrays.asList(new String[]{ "source.key=" + sourceKey.replace("\\", "/"), "source.cert=" + sourceCert.replace("\\", "/") }));

Of course, this looks cleaner. Changed.

GChuf · 2026-06-23T07:16:17Z

As far as I can tell, the two JDK8/IBM related commits aren't specific to Windows so they shouldn't be associated with ARTEMIS-6116 either.

You're right - moving these to a separate issue as well.

GChuf · 2026-06-25T07:37:09Z

@jbertram you mentioned you tested my changes as well - what Windows version are you using? I am getting different results on Windows10 and Windows11 it seems.

jbertram · 2026-06-26T13:43:31Z

I was testing on Windows 10, but I went back and tested again after you responded and it looks like the slashes are indeed a real problem.

GChuf · 2026-07-11T10:16:45Z

@jbertram can you review this again and let me know if anything needs changing? I think I solved everything, tested on win10 and win11.
There's only 1 remaining test failing in Artemis Server (on my machines, anyway), but that's because running "main" without arguments hangs on windows instead of exiting:
MainTest.testNull » Timeout testNull() timed out after 5 seconds
Maybe we should solve that behavior in the server code, not just "fix" the test scenario.

Also, the last commit is solving an edge case. Error only happens when user does not have permissions to create symlinks.

p.s. does it make sense to create a github job to run builds/tests on Windows?

Reduce network timeout checked because windows reports lower timeouts

Fixes issues related to backslashes

…n Windows

GChuf · 2026-07-13T08:17:35Z

Rebased on main.

GChuf force-pushed the ARTEMIS-6116 branch from b2d0ebc to 9bb09b3 Compare June 12, 2026 11:22

jbertram reviewed Jun 19, 2026

View reviewed changes

Comment thread pom.xml Outdated

GChuf force-pushed the ARTEMIS-6116 branch 5 times, most recently from cd991dc to bf5d341 Compare June 20, 2026 10:42

jbertram reviewed Jun 22, 2026

View reviewed changes

GChuf force-pushed the ARTEMIS-6116 branch 3 times, most recently from 34fe053 to 4660c46 Compare June 25, 2026 07:34

GChuf force-pushed the ARTEMIS-6116 branch 4 times, most recently from 79538d1 to 7fb5cf0 Compare July 11, 2026 10:08

GChuf added 9 commits July 13, 2026 10:16

ARTEMIS-6116 Remove file prefix from activemq-surefire-argline

6cc7d82

ARTEMIS-6116 Fix NetworkHealthTest for Windows

8ed390d

Reduce network timeout checked because windows reports lower timeouts

ARTEMIS-6116 Fix "cannot delete resources" error

dee1e18

ARTEMIS-6116 Use USERPROFILE on Windows

2b9b553

ARTEMIS-6116 Replace line endings for stderr

57fc78e

ARTEMIS-6116 Add non-Posix file permissions check for Windows

b9143c5

ARTEMIS-6116 WebServerComponentTest fixes for Windows

697087f

Fixes issues related to backslashes

ARTEMIS-6116 Close p.properties file after saving contents

7e5822c

ARTEMIS-6116 Fix keystore path for Windows

1060c36

GChuf added 6 commits July 13, 2026 10:16

ARTEMIS-6116 Fix token path for Windows

c48f270

ARTEMIS-6116 Always use \n as line endings for test configuration file

d122348

ARTEMIS-6116 Release file locks in test with manager.stop()

0657b1d

ARTEMIS-6116 Replace ':' in filename with '_'

0204159

ARTEMIS-6116 Release file handles in MessageSerializerTest

8954a33

ARTEMIS-6116 Catch missing permissions error when creating symlinks o…

c8a05c2

…n Windows

GChuf force-pushed the ARTEMIS-6116 branch from 7fb5cf0 to c8a05c2 Compare July 13, 2026 08:17

Uh oh!

Conversation

GChuf commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbertram Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

GChuf Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbertram commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbertram Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

GChuf Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

jbertram Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

GChuf Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

GChuf commented Jun 23, 2026

Uh oh!

GChuf commented Jun 25, 2026

Uh oh!

jbertram commented Jun 26, 2026

Uh oh!

GChuf commented Jul 11, 2026

Uh oh!

GChuf commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GChuf commented Jun 12, 2026 •

edited

Loading

jbertram commented Jun 22, 2026 •

edited

Loading