Skip to content

[CALCITE-5584] Publish website action only triggers for the last commit in the chain - #5136

Merged
rubenada merged 1 commit into
apache:mainfrom
rubenada:CALCITE-5584
Aug 10, 2026
Merged

[CALCITE-5584] Publish website action only triggers for the last commit in the chain#5136
rubenada merged 1 commit into
apache:mainfrom
rubenada:CALCITE-5584

Conversation

@rubenada

Copy link
Copy Markdown
Contributor

Jira Link

CALCITE-5584

Changes Proposed

Adjust publish-non-release-website-updates.yml to be able to process up to 20 commits (limit of github.event.commits); that should be enough for Calcite, where normally only one or a few commits land together.

@xuzifu666 xuzifu666 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zabetak zabetak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @rubenada ! I assume that you did all necessary testing on your private fork is that correct?

Comment thread .github/workflows/publish-non-release-website-updates.yml Outdated
Comment thread .github/workflows/publish-non-release-website-updates.yml Outdated
Comment thread .github/workflows/publish-non-release-website-updates.yml
@rubenada

Copy link
Copy Markdown
Contributor Author

@zabetak I have tested the patch on my fork and it seems to work fine: all commits are cherry-picked. I also tested a conflict scenario, and it worked fine too.

@sonarqubecloud

Copy link
Copy Markdown

@zabetak zabetak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra tests @rubenada . Code LGTM!

@rubenada rubenada added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Aug 10, 2026
@rubenada
rubenada merged commit ed9fcee into apache:main Aug 10, 2026
35 checks passed
@rubenada

Copy link
Copy Markdown
Contributor Author

Thanks for the review @xuzifu666 , @zabetak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants