Add the ASF licence header to cli/completer_test.go - #221
Conversation
The file landed without a header in apache#214, so the Apache RAT check has been failing on main since 9a04d5b.
|
✅ Build complete for PR #221. 📦 Binary artifacts are available in the workflow run (expires on September 20, 2026).
|
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Adds the standard Apache Software Foundation (ASF) license header to cli/completer_test.go so Apache RAT no longer flags it as an unapproved license file.
Changes:
- Added the 16-line ASF license header to
cli/completer_test.goto satisfy Apache RAT checks.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Problem
The Apache RAT check has been failing on
mainsince 9a04d5b (the #214 merge):cli/completer_test.golanded in #214 without the ASF licence header, so RAT counts it as unapproved and the workflow'sUnapproved: 0gate fails.Fix
Add the standard 16-line ASF header, the same one every other
.gofile in the repo carries.Testing
Ran the exact command from
.github/workflows/rat.yamllocally with Apache RAT 0.18:Unapproved: 1—/cli/completer_test.goUnapproved: 0Also
gofmtclean,go build ./...OK,go test ./...passes.