Skip to content

Add the ASF licence header to cli/completer_test.go - #221

Merged
borisstoyanov merged 1 commit into
apache:mainfrom
borisstoyanov:fix-rat-header
Sep 10, 2026
Merged

Add the ASF licence header to cli/completer_test.go#221
borisstoyanov merged 1 commit into
apache:mainfrom
borisstoyanov:fix-rat-header

Conversation

@borisstoyanov

Copy link
Copy Markdown
Contributor

Problem

The Apache RAT check has been failing on main since 9a04d5b (the #214 merge):

! Unapproved:         1    A count of unapproved licenses.
! /cli/completer_test.go

cli/completer_test.go landed in #214 without the ASF licence header, so RAT counts it as unapproved and the workflow's Unapproved: 0 gate fails.

Fix

Add the standard 16-line ASF header, the same one every other .go file in the repo carries.

Testing

Ran the exact command from .github/workflows/rat.yaml locally with Apache RAT 0.18:

java -jar apache-rat-0.18/apache-rat-0.18.jar -d . -E .rat-excludes
  • Before: Unapproved: 1/cli/completer_test.go
  • After: Unapproved: 0

Also gofmt clean, go build ./... OK, go test ./... passes.

The file landed without a header in apache#214, so the Apache RAT check has
been failing on main since 9a04d5b.
Copilot AI lite review requested due to automatic review settings September 10, 2026 07:12

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishesh92 vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

Copy link
Copy Markdown

✅ Build complete for PR #221.

📦 Binary artifacts are available in the workflow run (expires on September 20, 2026).

Note: Download artifacts by clicking on the workflow run link above, then scroll to the "Artifacts" section.
Artifacts from PR builds are for testing only and may contain unreviewed, malicious code.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Adds the standard Apache Software Foundation (ASF) license header to cli/completer_test.go so Apache RAT no longer flags it as an unapproved license file.

Changes:

  • Added the 16-line ASF license header to cli/completer_test.go to satisfy Apache RAT checks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@borisstoyanov
borisstoyanov merged commit d50ae40 into apache:main Sep 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants