Clarify KVM import template requirement by andrijapanicsb · Pull Request #13126 · apache/cloudstack

andrijapanicsb · 2026-05-07T16:25:05Z

Description

importUnmanagedInstance documents templateid as an optional parameter, but KVM unmanaged instance import currently requires a template and fails when one is not supplied.

This updates the generated API parameter description for templateid to explicitly mention that it is required when importing an unmanaged KVM instance. It avoids the current mismatch between API docs and runtime behavior without changing import semantics.

Fixes #13067

Tests

Added ImportUnmanagedInstanceCmdTest coverage to verify the templateid API parameter description includes the KVM requirement. Deleted

codecov · 2026-05-07T16:33:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.92%. Comparing base (10d3e11) to head (850ab46).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #13126   +/-   ##
=========================================
  Coverage     17.91%   17.92%           
- Complexity    16109    16113    +4     
=========================================
  Files          5928     5928           
  Lines        534964   534964           
  Branches      65463    65463           
=========================================
+ Hits          95865    95876   +11     
+ Misses       428191   428180   -11     
  Partials      10908    10908

Flag	Coverage Δ
uitests	`4.02% <ø> (ø)`
unittests	`18.99% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

andrijapanicsb · 2026-05-07T23:28:04Z

@blueorangutan package kvm

blueorangutan · 2026-05-07T23:30:03Z

@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled withkvm SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2026-05-08T00:42:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17772

andrijapanicsb · 2026-05-13T23:45:09Z

@blueorangutan test

blueorangutan · 2026-05-13T23:46:03Z

@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

andrijapanicsb · 2026-05-15T20:50:39Z

@blueorangutan test ol8 kvm-ol8 keepEnv

andrijapanicsb · 2026-05-25T22:38:55Z

@blueorangutan test

blueorangutan · 2026-05-25T22:40:04Z

@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-05-26T13:36:27Z

[SF] Trillian test result (tid-16173)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50487 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13126-t16173-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

nvazquez

@andrijapanicsb the text on the description looks good, IMO the API must also check the hypervisor type and the importing operation and fail in case it is not passed for KVM import unmanaged instance.

andrijapanicsb · 2026-05-29T00:37:26Z

@andrijapanicsb the text on the description looks good, IMO the API must also check the hypervisor type and the importing operation and fail in case it is not passed for KVM import unmanaged instance.

In the UI for Migrating from VMware to KVM etc - there is no option to even select a template - seems we always (or UI does ot) assign the dummy template

sonarqubecloud · 2026-05-29T01:28:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nvazquez

Code LGTM

Let's target the PR to branch 4.22 instead of main branch so can get into 4.22.2 as well

nvazquez · 2026-08-26T16:44:22Z

Hi @andrijapanicsb are you ok addressing the comment and rebasing the PR to the 4.22 branch? If not, I can help with that

DaanHoogland · 2026-09-02T14:20:46Z

ping @andrijapanicsb , will you rebase (and apply my suggestion?

…mportUnmanagedInstanceCmdTest.java unneeded

…mportUnmanagedInstanceCmd.java Co-authored-by: dahn <daan@onecht.net>

nvazquez · 2026-09-09T19:20:57Z

Hi @andrijapanicsb @DaanHoogland - I have rebased the fix to branch 4.22 and applied Daan's suggestion on the parameter description

@blueorangutan package

blueorangutan · 2026-09-09T19:22:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

nvazquez · 2026-09-09T19:27:45Z

@blueorangutan package

blueorangutan · 2026-09-09T19:30:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2026-09-09T20:39:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

blueorangutan · 2026-09-09T21:05:30Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19189

nvazquez · 2026-09-09T21:09:07Z

@blueorangutan test

blueorangutan · 2026-09-09T21:10:03Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

andrijapanicsb requested a review from shwstppr May 7, 2026 16:29

boring-cyborg Bot added the component:api label May 7, 2026

andrijapanicsb requested review from Pearl1594 and sureshanaparti May 13, 2026 08:52

apache deleted a comment from blueorangutan May 25, 2026

andrijapanicsb added this to the 4.23.0 milestone May 26, 2026

DaanHoogland reviewed May 26, 2026

View reviewed changes

Comment thread ...src/test/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmdTest.java Outdated

nvazquez reviewed May 28, 2026

View reviewed changes

Comment thread ...src/test/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmdTest.java Outdated

DaanHoogland approved these changes May 29, 2026

View reviewed changes

weizhouapache modified the milestones: 4.23.0, 4.22.2 Jun 29, 2026

andrijapanicsb requested review from kiwiflyer and wido August 6, 2026 23:09

nvazquez approved these changes Aug 24, 2026

View reviewed changes

This was referenced Aug 24, 2026

Clarification on the templateid parameter for importUnmanagedInstances API apache/cloudstack-documentation#676

Merged

Optional templateid param fails for KVM VM import #13067

Open

DaanHoogland reviewed Aug 26, 2026

View reviewed changes

Comment thread api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmd.java Outdated

DaanHoogland added this to CloudStack Testing Aug 31, 2026

github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 31, 2026

DaanHoogland moved this from Backlog to conflict/waiting in CloudStack Testing Sep 1, 2026

DaanHoogland assigned sureshanaparti Sep 1, 2026

andrijapanicsb added 2 commits September 9, 2026 16:17

Clarify KVM import template requirement

0e5342d

Delete api/src/test/java/org/apache/cloudstack/api/command/admin/vm/I…

e26017b

…mportUnmanagedInstanceCmdTest.java unneeded

nvazquez force-pushed the fix/clarify-kvm-import-templateid-requirement branch from d6444de to e26017b Compare September 9, 2026 19:18

boring-cyborg Bot added component:agent component:compute component:kvm component:orchestration component:saml component:storage component:UI labels Sep 9, 2026

nvazquez changed the base branch from main to 4.22 September 9, 2026 19:18

Update api/src/main/java/org/apache/cloudstack/api/command/admin/vm/I…

885c900

…mportUnmanagedInstanceCmd.java Co-authored-by: dahn <daan@onecht.net>

Include unmanaged instance in the description for extra clarity

850ab46

Uh oh!

Conversation

andrijapanicsb commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Tests

Uh oh!

codecov Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

andrijapanicsb commented May 7, 2026

Uh oh!

blueorangutan commented May 7, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

andrijapanicsb commented May 13, 2026

Uh oh!

blueorangutan commented May 13, 2026

Uh oh!

andrijapanicsb commented May 15, 2026

Uh oh!

andrijapanicsb commented May 25, 2026

Uh oh!

blueorangutan commented May 25, 2026

Uh oh!

blueorangutan commented May 26, 2026

Uh oh!

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andrijapanicsb commented May 29, 2026

Uh oh!

sonarqubecloud Bot commented May 29, 2026

Quality Gate passed

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nvazquez commented Aug 26, 2026

Uh oh!

DaanHoogland commented Sep 2, 2026

Uh oh!

nvazquez commented Sep 9, 2026

Uh oh!

blueorangutan commented Sep 9, 2026

Uh oh!

nvazquez commented Sep 9, 2026

Uh oh!

blueorangutan commented Sep 9, 2026

Uh oh!

sonarqubecloud Bot commented Sep 9, 2026

Quality Gate passed

Uh oh!

blueorangutan commented Sep 9, 2026

Uh oh!

nvazquez commented Sep 9, 2026

Uh oh!

blueorangutan commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

andrijapanicsb commented May 7, 2026 •

edited

Loading

codecov Bot commented May 7, 2026 •

edited

Loading