Skip to content

ui: link account to LDAP - #13950

Draft
DaanHoogland wants to merge 3 commits into
mainfrom
ghi11473-link-account-to-ldap-ui
Draft

ui: link account to LDAP#13950
DaanHoogland wants to merge 3 commits into
mainfrom
ghi11473-link-account-to-ldap-ui

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #11473

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland added this to the 4.24.0 milestone Aug 22, 2026
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.79%. Comparing base (5e5ae0c) to head (2713646).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13950      +/-   ##
============================================
+ Coverage     19.72%   19.79%   +0.06%     
- Complexity    19941    20014      +73     
============================================
  Files          6371     6371              
  Lines        575738   575929     +191     
  Branches      70471    70514      +43     
============================================
+ Hits         113582   113981     +399     
+ Misses       449810   449522     -288     
- Partials      12346    12426      +80     
Flag Coverage Δ
uitests 3.53% <ø> (+0.11%) ⬆️
unittests 21.06% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13950 (QA-JID-980)

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.68%
Branch coverage 18.89%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@DaanHoogland DaanHoogland moved this from Backlog to Ready in CloudStack Testing Aug 31, 2026
@sudo87 sudo87 moved this from Ready to In progress in CloudStack Testing Sep 7, 2026
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

lgtm, tested with openldap locally.
...
2. No option to unlink the account

I believe this is a separate feature (also requested in some issue)

@DaanHoogland DaanHoogland removed their assignment Sep 7, 2026

@sudo87 sudo87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested with openldap locally.

few things to note:

  1. Link action remains active after successful linking to ldap, relink will error out with "Entity already exists" for the same account.
  2. No option to unlink the account

Comment thread ui/src/config/section/account.js Outdated
options: ['GROUP', 'OU']
},
accounttype: {
options: ['0', '2']

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 & 2 is confusing for the end user.
Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, will have to see if we have a translation util yet (or make one)

@DaanHoogland
DaanHoogland marked this pull request as draft September 7, 2026 12:46
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

UI : Support linkAccountToLdap from Account Page

4 participants