Resolve column name in ResultSetIterator.set (1.X) - #428
Merged
garydgregory merged 1 commit intoJul 24, 2026
Merged
Conversation
port of apache#426. the read path resolves the dyna-property name to the real column name via getColumnName, but set passed the raw name to updateObject, so with the default lowerCase a mixed-case column update targeted the wrong column. Same fix and regression test as master, adapted to the JUnit 3 style on this branch.
7 tasks
garydgregory
added a commit
that referenced
this pull request
Jul 24, 2026
- Use the generics diamond notation. - Sort members. - Reduce vertical whitespace.
| */ | ||
| public void testSetUsesColumnName() throws Exception { | ||
|
|
||
| final AtomicReference<String> updatedColumn = new AtomicReference<String>(); |
Member
There was a problem hiding this comment.
Hi @rootvector2
In the future, you do not need the extra generics noise, you can simply say:
final AtomicReference<String> updatedColumn = new AtomicReference<>();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #426 to 1.X.
setpasses the raw lower-cased property name toResultSet.updateObjectwhile the read path resolves it throughgetColumnNamefirst, so under the defaultlowerCasean update to a mixed-case column targets the wrong column or throws on a case-sensitive driver.Same one-line fix and regression test as master, with the test adapted to the JUnit 3 style on this branch (and using
AtomicReferenceper the review on #426).DynaResultSetTest.testSetUsesColumnNamefails on clean1.Xwithexpected:<string[P]roperty> but was:<string[p]roperty>and passes with the change.Note: as on #417,
mvnon a clean1.Xcheckout failsLocaleBeanificationTest#testContextClassloaderIndependencein my environment (it passes in isolation), so no fully green default-goal run locally; the failure is identical with and without this change.apache-rat:checkandcheckstyle:checkpass.mvn; that'smvnon the command line by itself.