feat: Support List/ListView types in approx_distinct#23443
Open
mkleen wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
sqllogictest
nuno-faria
approved these changes
Jul 10, 2026
nuno-faria
left a comment
nuno-faria
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mkleen, double checked with DuckDB.
Jefffrey
approved these changes
Jul 11, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
probably could include largelist + fixedsizelist (maybe even the view variants) in this PR
mkleen
changed the title
mkleen
force-pushed
the
list_approx_distinct
branch
from
25cb2b1 to
53919e3
Compare
Contributor
Author
Yes, good idea. I added them. |
mkleen
changed the title
Contributor
Author
|
Thanks for the review @Jefffrey @nuno-faria |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
approx_distinctfunction #22989 but does not close it. More types are coming.Rationale for this change
ListLargeList,FixedSizeList,ListView,LargeListViewtype forapprox_distinctWhat changes are included in this PR?
HLLAccumulatorandHllGroupsAccumulatorto supportListLargeList,FixedSizeList,ListView,LargeListViewaggregate.sltAre these changes tested?
Yes
Are there any user-facing changes?
Yes,
approx_distinctsupports nowListLargeList,FixedSizeList,ListView,LargeListViewbut no breaking changes.