[MINOR][VL] re-enable the tests on Char/VarChar - #12811
Open
zhouyuan wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_reenable_char_tests
branch
from
August 18, 2026 11:38
7454d66 to
4d06f94
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Re-enables previously excluded CHAR/VARCHAR test cases for the Velox backend after a Velox rebase, aiming to restore coverage for nested complex-type scenarios.
Changes:
- Removed exclusions for nested
ARRAY<STRUCT<char/varchar>>test cases in Spark 4.0 / 4.1 Velox test settings. - Re-enabled specific Gluten-overridden test cases in Spark 3.5 Velox test settings by removing
excludeGlutenTest/ related exclusions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables previously excluded char/varchar nested array-of-struct tests for Spark 4.1. |
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables previously excluded char/varchar nested array-of-struct tests for Spark 4.0. |
| gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Removes exclusions for Gluten-overridden char/varchar tests for Spark 3.5. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
re-enable the failed tests due to velox rebase on 8/12
How was this patch tested?
pass GHA
Was this patch authored or co-authored using generative AI tooling?