Skip to content

fix: track batch position delete references - #842

Open
u70b3 wants to merge 3 commits into
apache:mainfrom
u70b3:fix-position-delete-batch-metadata
Open

fix: track batch position delete references#842
u70b3 wants to merge 3 commits into
apache:mainfrom
u70b3:fix-position-delete-batch-metadata

Conversation

@u70b3

@u70b3 u70b3 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • collect referenced data-file paths when writing position deletes as an Arrow batch
  • update referenced-path metadata only after the underlying write succeeds
  • reject null batch inputs, null file paths, and sliced (non-zero offset) batches
  • cover single-file, multi-file, mixed, empty, invalid, and failed-then-successful batches

Testing

  • pre-commit run --files src/iceberg/data/position_delete_writer.cc src/iceberg/test/data_writer_test.cc
  • build-gcc14/src/iceberg/test/data_test (159 tests passed)
  • git diff --check

u70b3 added 3 commits July 24, 2026 13:02
Take ownership before validation so early-return paths honor the FileWriter contract and do not leak Arrow buffers. Assert that rejected sliced and null-path batches are released.
@u70b3

u70b3 commented Aug 11, 2026

Copy link
Copy Markdown
Author

Hi @wgtmac, gentle ping for a review when you have a moment. This has been sitting for about two weeks; all CI checks are green and it merges cleanly against the latest main. The change tracks referenced data-file paths for batch position-delete writes so referenced_data_file and bounds metadata match the WriteDelete path, and hardens ownership/validation for rejected batches. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant