KNOX-3408 - Allow no actor token in JWTFederationFilter.handleTokenExchange - #1339
Merged
Conversation
added 2 commits
August 5, 2026 22:41
…ter.handleTokenExchange and TokenExchangePrincipal handling in AbstractIdentityAssertionFilter#continueChainAsPrincipal handling Only unit tests are added for existing functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3408 - Allow no actor token in JWTFederationFilter.handleTokenExchange
What changes were proposed in this pull request?
RFC 8693 requires that the actor token be optional for token exchange.
Change the handleTokenExchange method to allow a missing actor token.
When actor_token is absent, the Subject has the subject from the subject token
as PrimaryPrincipal with no TokenExchangePrincipal. Note that headless
delegation using ImpersonatedPrincipal is currently not represented in this path.
How was this patch tested?
A unit test for the new path is added. Regression tests for subject handling in
JWTFederationFilter.handleTokenExchange and TokenExchangePrincipal handling in AbstractIdentityAssertionFilter.continueChainAsPrincipal handling were also
added and run before the feature change to show no regression.
Integration Tests
N/A