Adjust PMD violation ceilings to PMD 7 counts - #485
Merged
Conversation
The maven-pmd-plugin 3.15.0 to 3.28.0 bump (#479) switched from PMD 6 to PMD 7.17.0, which finds a different violation mix in most modules. Ratchet each module's `pmd.maxAllowedViolations` to the new actual count so the build passes again. The counts rise in some modules and drop in others (flume-ng-sdk goes from 170 to 30); fixing the violations themselves remains a TODO. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
ppkarwasz
force-pushed
the
fix/pmd-7-violation-ceilings
branch
from
July 31, 2026 22:18
9c62217 to
cef4fb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot PRs were auto-merged without the build being a required check, and #479 (the maven-minor-updates group) bumped
maven-pmd-plugin3.15.0 to 3.28.0, moving from PMD 6 to PMD 7.17.0.The new PMD finds a different violation mix, and
flume-ng-corenow exceeds itspmd.maxAllowedViolationsceiling (69 found vs 64 allowed), breaking the build on all platforms. The merge commits triggered no push builds (bot-token merges do not trigger workflows), so trunk is red without CI showing it.This ratchets every module's
pmd.maxAllowedViolationsto the actual PMD 7.17.0 count:ganglia-monitor and syslog-source were previously PMD-clean; they only fail once the reactor gets past flume-ng-core, so their new ceilings are needed too. Fixing the violations themselves (mostly
UnnecessaryModifierin flume-ng-core) remains a TODO.Verified locally with a full
mvn -T1C verify(tests included): BUILD SUCCESS, all modules at or under their ceilings.The other auto-merged bumps are fine: JUnit Jupiter 6.1.2 and apacheds-jdbm1 built green standalone, and the mockserver-netty PR only hit the known-flaky
TestExecSource.testBatchTimeouton Windows.