Repository navigation
Conversation
mbien
commented
Sep 2, 2026
Comment on lines
+113
to
118
| // TODO list never read? | ||
| List<MatchHighlightRequest> matchHighlightRequests = new ArrayList<>(); | ||
| for (MatchHighlightRequest hr : request.getMatchHighlightRequests()) { | ||
| Query rewrittenQuery = hr.getQuery().rewrite(indexSearcher.getIndexReader()); | ||
| Query rewrittenQuery = hr.getQuery().rewrite(indexSearcher); | ||
| matchHighlightRequests.add(new MatchHighlightRequest(hr.getField(), rewrittenQuery, hr.getHighlightMode())); | ||
| } |
Member
Author
There was a problem hiding this comment.
this section appears to be a no-op. Maybe it was meant to populate the field above instead of the variable with the same name?
mbien
commented
Sep 2, 2026
Comment on lines
+201
to
+208
| hitCount += collector.getTotalHits(); | ||
| hitCount += topdocs.totalHits.value(); |
Member
Author
There was a problem hiding this comment.
totalHits value is now a long, the maven-indexer response api is still using int, I didn't change that. (see casts marked with TODO)
Member
Member
Author
|
sure, i can try to rebase this PR. |
Member
Author
|
modernizer wants me to refactor unrelated code due to the bump of the lower bound. Haven't done that. |
Member
Author
|
I could set |
- lower bound becomes JDK 21 - migrated lucene usage - temp: set modernizer plugin failOnViolations=false until codebase is modernized (lower bound bump unlocked more cleanups)
mbien
commented
Sep 29, 2026
| void indexPackingRequestPath() { | ||
| IndexPackingRequest request = | ||
| new IndexPackingRequest(mock(IndexingContext.class), mock(IndexReader.class), dir); | ||
| IndexPackingRequest request = new IndexPackingRequest(mock(IndexingContext.class), mock(LeafReader.class), dir); |
Member
Author
There was a problem hiding this comment.
in case anyone is wondering: IndexReader is no longer mockable since its sealed+abstract, so I had to pick a leaf interface.
mbien
marked this pull request as ready for review
September 29, 2026 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only minor changes were needed. There is no hurry to get this in, but I have done something similar for the NetBeans code indexer (apache/netbeans#9593), so I thought to open a PR for the maven-indexer too.
edit: pr is now smaller due to #766 (comment)
failOnViolations=falseuntil codebase is modernized (lower bound bump unlocked more cleanups)https://lucene.apache.org/core/10_5_1/changes/Changes.html
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.