Skip to content

newt/project: Follow version deps for commit pinned repos - #637

Merged
sjanc merged 1 commit into
apache:masterfrom
sjanc:project_commit_deps
Oct 16, 2026
Merged

sjanc merged 1 commit into
apache:masterfrom
sjanc:project_commit_deps

Conversation

@sjanc

@sjanc sjanc commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

A repo pinned to a commit hash (e.g. "-commit") had all its dependencies followed while loading the project, including those listed only for old releases. This cloned repos that were not used, e.g. apache-mynewt-mcumgr for core pinned to a master commit in CI.

Ignore the commit and map the requirement's version number instead, as Repo.DepsForVersion does during install. All dependencies are still followed if the version cannot be mapped.

Assisted-by: Claude:claude-opus-5-5

A repo pinned to a commit hash (e.g. "<sha>-commit") had all its
dependencies followed while loading the project, including those
listed only for old releases. This cloned repos that were not used,
e.g. apache-mynewt-mcumgr for core pinned to a master commit in CI.

Ignore the commit and map the requirement's version number instead,
as Repo.DepsForVersion does during install. All dependencies are
still followed if the version cannot be mapped.

Assisted-by: Claude:claude-opus-5-5
@sjanc
sjanc merged commit 461da71 into apache:master Oct 16, 2026
112 of 113 checks passed
@sjanc
sjanc deleted the project_commit_deps branch October 16, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants