Load OCSP test status from certificate database - #1066
Draft
sainadh777 wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@markt-asf, when you have a chance, could you review this test-infrastructure change? You authored all three prior changes to the in-process OCSP responder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.dbRationale
The in-process OCSP responder duplicated serial numbers from the certificate
database. Regenerating the test certificates could therefore leave the
responder out of sync with the fixtures. Reading the database at responder
initialization keeps the OCSP status source of truth with the certificates.
This is test infrastructure only. It does not change Tomcat runtime behavior
or public APIs, so no changelog entry is needed.
Validation
Environment: Linux arm64 (
eclipse-temurin:21-jdk-jammy), Java 21, Ant1.10.15.
ant -Dbase.path=/workspace-cache -Dexecute.validate=true validateant -Dbase.path=/workspace-cache -Dtest.entry=org.apache.tomcat.util.net.ocsp.TestTesterOcspResponderServlet testant -Dbase.path=/workspace-cache -Dtest.name='**/ocsp/Test*.java' testant -Dbase.path=/workspace-cache cleanfollowed byant -Dbase.path=/workspace-cacheant -Dbase.path=/workspace-cache clean test._*files, including a false JAR fixture, so that non-clean run was stopped after unrelated manifest-read errors.._*files and SHA-256 matching all changed files.output/build/bin/catalina.sh run, required HTTP 200 fromhttp://127.0.0.1:8080/(11,229-byte response), ranshutdown.sh, and verified the server exited with status 0.The committed versions of all changed files match the SHA-256 hashes of the
files used for the successful Linux validation.