[ZEPPELIN-6548] Use specific exceptions for Spark Scala fallback detection#5340
Open
miinhho wants to merge 1 commit into
Open
[ZEPPELIN-6548] Use specific exceptions for Spark Scala fallback detection#5340miinhho wants to merge 1 commit into
miinhho wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR refines exception types in
SparkInterpreterLauncherwhen the fallback Spark Scala version detection validates theSPARK_HOME/jarslayout.Previously,
detectSparkScalaVersionByReplClass(...)threw genericExceptionfor expected validation failures such as missing or duplicatespark-repljars, or an unsupportedspark-replScala suffix. This PR replaces those generic throw sites with more specific exception types while keeping the existing messages and caller behavior unchanged.Missing or duplicate
spark-repljars now throwIOException, and an unrecognized Scala suffix now throwsIllegalArgumentException.This PR is a follow-up to ZEPPELIN-6464
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
Questions: