Repository navigation
polish(desktop): name React Native apps in per-app labels - #3067
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a worktree with several apps, the log viewer App picker, the worktree page and the sidebar row name each app by its platforms only. In the stim repo the picker read "macOS" and "iOS · Android", which looked like a grouped platform filter rather than two apps.
Solution
An app that runs on iOS and/or Android is labelled "React Native" in place of those platforms. Any macOS or Web platform follows it ("React Native · Web"), and the folder suffix when two apps get the same label is unchanged ("React Native · apps/a"). The status payload has no framework field, so the label still comes from the platform set. Single-app worktrees show no picker and are unchanged. The phone app mirrors the rule in
apps/mobile/src/lib/worktree-page.tsand both read the sharedworktree-page-vectors.json, which is updated in place.Polish change (copy only), collected under #3065.
Test plan
stim macosand drove it with agent-device (--surface app);stim logs --source agentlists the taps and snapshots.pnpm test src/lib/worktree-page.test.tsinapps/mobilepasses against the updated vectors; Desktop'sWorktreePageTestsreads the same file and runs in CI.Fixes #3065