Skip to content

polish(desktop): name React Native apps in per-app labels - #3067

Merged
janicduplessis merged 1 commit into
mainfrom
polish/3065-app-labels
Oct 9, 2026
Merged

janicduplessis merged 1 commit into
mainfrom
polish/3065-app-labels

Conversation

@janicduplessis

Copy link
Copy Markdown
Collaborator

Description

In a worktree with several apps, the log viewer App picker, the worktree page and the sidebar row name each app by its platforms only. In the stim repo the picker read "macOS" and "iOS · Android", which looked like a grouped platform filter rather than two apps.

Solution

An app that runs on iOS and/or Android is labelled "React Native" in place of those platforms. Any macOS or Web platform follows it ("React Native · Web"), and the folder suffix when two apps get the same label is unchanged ("React Native · apps/a"). The status payload has no framework field, so the label still comes from the platform set. Single-app worktrees show no picker and are unchanged. The phone app mirrors the rule in apps/mobile/src/lib/worktree-page.ts and both read the shared worktree-page-vectors.json, which is updated in place.

Polish change (copy only), collected under #3065.

Test plan

  • Ran this worktree's Desktop with stim macos and drove it with agent-device (--surface app); stim logs --source agent lists the taps and snapshots.
  • Log viewer App picker, open: lists "macOS" and "React Native".

picker

  • Inspector Build section and the Build sheet: platform rows and tabs are unchanged.

inspector
build sheet

  • pnpm test src/lib/worktree-page.test.ts in apps/mobile passes against the updated vectors; Desktop's WorktreePageTests reads the same file and runs in CI.
  • Not checked live: the worktree "..." menu, the inspector Metro section and the sidebar row problem text, which use the same label function.

Fixes #3065

@janicduplessis
janicduplessis marked this pull request as ready for review October 9, 2026 00:59
@janicduplessis
janicduplessis merged commit 32e7726 into main Oct 9, 2026
3 checks passed
@janicduplessis
janicduplessis deleted the polish/3065-app-labels branch October 9, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

desktop: name RN apps "React Native" in the App picker and per-app labels

1 participant