Skip to content

[BOURNE-3137] Resolve Dependabot alerts - #36

Merged
adhurjaty merged 1 commit into
mainfrom
fix-dependabot-critical-high-netty-pmd
Sep 29, 2026
Merged

adhurjaty merged 1 commit into
mainfrom
fix-dependabot-critical-high-netty-pmd

Conversation

@chao-shawn

Copy link
Copy Markdown

Resolves all open critical and high severity Dependabot alerts on this repo (and, as a side effect, every open netty and pmd-core moderate alert too, since the patched versions are the same properties).

Changes

Property Before After Why
netty.version 4.1.130.Final 4.1.138.Final Highest patched version required by any netty alert was 4.1.137.Final; 4.1.138.Final is the latest 4.1.x on Maven Central.
pmd.version 7.6.0 7.28.0 Critical pmd-core alert is patched in 7.10.0, the moderate one in 7.22.0.

Alerts addressed

Critical (1)

High (11) — all io.netty codec artifacts

Also resolved (moderate) — #28, #25, #20, #19, #18, #16, #11, #8, #7, #6, #3

Alert #1 (org.keycloak:keycloak-core, low, in contrib/custom-representations/pom.xml) is not addressed here — it is low severity, has no patched version published, and lives in a separate contrib module. Out of scope for this PR.

Verification

  • ./mvnw compile pmd:check — passes (PMD 7.28.0 reports no new violations against the maven-pmd-plugin default ruleset; no custom ruleset in this repo).
  • ./mvnw test — 339 tests, 0 failures, 0 errors.
  • ./mvnw dependency:tree -Dincludes='io.netty:*' confirms netty-codec, netty-codec-http, and netty-codec-http2 all resolve to 4.1.138.Final.
  • Integration tests (*IT, Testcontainers + Keycloak) were not run locally — leaving those to CI, which is why this is a draft.

Note for reviewers

The other netty artifacts (netty-buffer, netty-common, netty-handler, netty-transport, ...) still resolve to 4.1.135.Final. That is because the keycloak-parent BOM is imported at pom.xml:155, before the netty-bom import at pom.xml:217, so keycloak-parent's netty pins win for everything not explicitly listed in our own dependencyManagement. This is why the three explicit netty-codec* entries exist at pom.xml:224-239 — they are the only way to override keycloak-parent. None of those other artifacts have open alerts, so this PR does not touch them, but it is worth knowing that the netty-bom import is currently shadowed and bumping netty.version alone would not move them.

🤖 Generated with Claude Code

Resolves all open critical and high severity Dependabot alerts:

- netty 4.1.130.Final -> 4.1.138.Final covers the netty-codec,
  netty-codec-http, and netty-codec-http2 alerts (highest patched
  version required by any alert was 4.1.137.Final).
- pmd 7.6.0 -> 7.28.0 covers the critical pmd-core alert (patched in
  7.10.0) and the medium one (patched in 7.22.0).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@chao-shawn chao-shawn self-assigned this Sep 29, 2026
@chao-shawn chao-shawn changed the title Bump netty to 4.1.138.Final and PMD to 7.28.0 for Dependabot alerts [BOURNE-3137] Resolve Dependabot alerts Sep 29, 2026
@chao-shawn
chao-shawn marked this pull request as ready for review September 29, 2026 17:50
@kermitapp

kermitapp Bot commented Sep 29, 2026

Copy link
Copy Markdown

@chao-shawn
chao-shawn requested a review from a team as a code owner September 29, 2026 17:50
@adhurjaty
adhurjaty merged commit 996be53 into main Sep 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants