Conversation
The tree imports both github.com/containerd/containerd/platforms and github.com/containerd/platforms. The first is a deprecation shim whose every symbol forwards to the second, so the two spellings name the same code and the split lives only in the source: pkg/build reaches for one in build.go and for the other in buildopts.go and frontend.go, and a reader has to open the vendored shim to learn that they agree. One module spells every platform now, the one dockerui itself imports and the one the shim forwards to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tree imports both
github.com/containerd/containerd/platformsandgithub.com/containerd/platforms. The first is a deprecation shim whose every symbol forwards to the second, so the two spellings name the same code and the split lives only in the source:pkg/buildreaches for one inbuild.goand for the other inbuildopts.goandfrontend.go, and a reader has to open the vendored shim to learn that they agree.One module spells every platform now, the one dockerui itself imports and the one the shim forwards to.
Motivation and Context
Housekeeping, and I want to be precise about what it is not: I checked the vendored shim before writing this, and
Format,Normalize, andDefaultSpecare one-line forwards, so no behaviour changes here and no normalization difference is being fixed. What changes is that the deprecated import path leaves the tree and a reader no longer has to establish that the two spellings agree.Testing
go build ./...andgo test ./...pass.