Test: add full payload JSON round-trip test in SystemStatusTests - #2221
Open
denizguney wants to merge 1 commit into
Open
Test: add full payload JSON round-trip test in SystemStatusTests#2221denizguney wants to merge 1 commit into
denizguney wants to merge 1 commit into
Conversation
Adds a new unit test to verify that system status payloads with nested paths and resource counts correctly round-trip through JSON encoding and decoding.
jglogan
reviewed
Aug 31, 2026
| let decoded = try JSONDecoder().decode(Application.StatusPayload.self, from: Data(json.utf8)) | ||
|
|
||
| #expect(decoded.paths?.appRoot == "/app") | ||
| #expect(decoded.resources?.containersTotal == 10) |
Contributor
There was a problem hiding this comment.
@denizguney This seems quite specific. Is it provable that these values will hold under all conditions?
Author
There was a problem hiding this comment.
You're right, these values are currently specific to this sample test payload. Our main goal here is to isolate and verify the correct parsing and type safety of the StatusPayload structure. However, I can make the test more robust or document that this is strictly a deterministic validation for this specific mock fixture. Let me know if you'd prefer a more dynamic approach or if adjusting the fixture assertions works best!"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new unit test to verify that system status payloads with nested paths and resource counts correctly round-trip through JSON encoding and decoding.
Important
All commits must be signed and verified. Pull requests containing unsigned or unverified commits cannot be built or merged. See the GitHub documentation for instructions.
For all but trivial fixes, make sure to first create a GitHub issue that concisely describes the bug or desired enhancement as justification for the change. Large PRs with no justifying issue will be closed.
Type of Change
Motivation and Context
Adds comprehensive JSON round-trip unit test coverage for SystemStatusTests to ensure correct encoding/decoding of nested paths and resource counts.
Testing