Repository navigation
Add shared credentials for kardoapp.com and kardopos.com - #1902
Open
hamitturkukaya wants to merge 1 commit into
Open
hamitturkukaya wants to merge 1 commit into
hamitturkukaya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall Checklist
for shared-credentials.json
shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use asharedassociation fromgoogle.co.iltogoogle.com, becausegoogle.co.ilredirects toaccounts.google.comfor sign in.)fromandto, thefromdomain(s) redirect to thetodomain to log in, and previously served their own sign-in forms, so users are likely to have accounts saved for them in password managers. (If afromdomain never served a sign-in form, there are no saved accounts for it to share, and it shouldn't be included. It is not our goal to document every redirect on the web; we only document redirects where users of password managers would find value.)Evidence
kardoapp.comandkardopos.comare the same Kardo POS product (restaurant / cafe point-of-sale) served by one backend.kardoapp.com(CN=kardoapp.com) listskardoapp.com,www.kardoapp.com,kardopos.comandwww.kardopos.comtogether in its Subject Alternative Names.https://kardoapp.com/andhttps://www.kardoapp.com/answer301tohttps://kardopos.com/.https://kardoapp.com/isletme/girisandhttps://kardopos.com/isletme/girisserve the same venue sign-in form and accept the same accounts. The newer venue dashboard athttps://venue.kardopos.com/authsigns in with those accounts too./.well-known/assetlinks.json, which declaresdelegate_permission/common.get_login_credsbetweenkardoapp.com,www.kardoapp.com,kardopos.com,www.kardopos.comandvenue.kardopos.com: