Repository navigation
Update password rule and change password URL for Pilot Flying J (pilo… - #1906
Open
TheNightmanCodeth wants to merge 1 commit into
Open
TheNightmanCodeth wants to merge 1 commit into
TheNightmanCodeth wants to merge 1 commit into
Conversation
…tcompany.com) Pilot Flying J moved from pilotflyingj.com to pilotcompany.com, and pilotflyingj.com now 301-redirects there. Change password URL: the old portal.pilotflyingj.com forgot-password URL now redirects to a login page. Point pilotflyingj.com at the "Forgot Password" link target on the new site, https://pilotcompany.com/api/auth/reset-password, and add pilotcompany.com. Neither domain has a working /.well-known/change-password (both return 404 or redirect to the home page). Password rule: the site requires at least 8 characters, upper and lowercase letters, at least one number, and at least one special character from
Contributor
@TheNightmanCodeth Should we also then add a from-to redirect quirk in shared-credentials.json from pilotflyingj.com to pilotcompany.com and also drop pilotflyingj.com from password-rules.json, because that domain will no longer generate passwords? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall Checklist
for password-rules.json
for change-password-URLs.json
https://example.com/.well-known/change-password)Summary
Pilot Flying J moved its web presence from
pilotflyingj.comtopilotcompany.com;pilotflyingj.comnow 301-redirects tohttps://pilotcompany.com. The existing quirks are stale.Changes
change-password-URLs.jsonpilotflyingj.com: replaced the deadhttps://portal.pilotflyingj.com/myrewards/forgot-password(now 301s to a login page) withhttps://pilotcompany.com/api/auth/reset-password.pilotcompany.comwith the same URL.password-rules.jsonpilotflyingj.com:minlength: 7; required: digit; allowed: lower, upper;->minlength: 8; required: lower; required: upper; required: digit; required: [-#$%&*?^];pilotcompany.comwith the same rule.Evidence
No well-known URL (checked with curl):
https://pilotcompany.com/.well-known/change-password-> 404 (identical to a nonexistent path)https://pilotflyingj.com/.well-known/change-password-> 301 ->https://pilotcompany.comChange password URL: this is the target of the "Forgot Password" link on the sign-in page. It 302s to PingOne's password-reset authorize flow (
auth.pingone.com). The link carries a?x-a-v=1query parameter; the response is identical without it, so it was dropped.Password rules: the reset form lists these requirements:
#?$%^&*-)The form's client-side validation enforces this with:
The rule requires a special character from the set the site lists on the form, which is a subset of what the validator accepts, so generated passwords are always accepted.
I used the Password Rules Validation Tool to generate 10000 passwords and put them all through the client-side validation script from the site itself.