Repository navigation
Przejęta SI nie kupi Doomsday ani fabryki borgów - #511
Merged
Merged
Conversation
can_use() było zdefiniowane na nieistniejących ścieżkach (destructive/, utility/ zamiast large/) i nikt go nie wywoływał. Teraz sklep ukrywa zablokowane moduły, a zakup je sprawdza.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co
Przejęta SI (
hijacked_ai) miała mieć zablokowane dwa moduły malf: Doomsday Device i Robotic Factory. Blokada nie działała:can_use()waquila/code/modules/antagonists/traitor/equipment/Malf_Modules.dmbyło przypięte do/datum/AI_Module/destructive/nuke_stationi/datum/AI_Module/utility/place_cyborg_transformer, a te moduły w core to/datum/AI_Module/large/...(DM po cichu tworzył nowe, nieużywane typy),can_use()nie było nigdzie wywoływane.Poprawka
/large/,mind?.dla bezpieczeństwa,ui_static_datasklepu modułów ukrywa moduły, których dana SI nie może kupić,purchase_moduleodrzuca zakup takiego modułu (gdyby ktoś wysłał akcję ręcznie).Zwykły malf (traitor-AI) widzi i kupuje wszystko jak dotąd.
Test
dm.exe -DCBT— 0 błędów. W grze niesprawdzone: nadać SI antaga Przejęta SI, otworzyć sklep modułów — nie powinno być Doomsday ani Robotic Factory; dla zwykłego malfa powinny być.