Repository navigation
Update Maven dependencies - #108
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Primary async methods can throw synchronously during lazy delegate initialization.
1 open finding
What changed in this PR
Updates Maven dependencies and adapts LazyChatModel to LangChain4j’s asynchronous API.
Changes:
- Upgrades dependencies and formatting tooling.
- Adds asynchronous
ChatModeldelegation methods.
| File | Description |
|---|---|
LazyChatModel.java |
Delegates newly introduced asynchronous operations. |
pom.xml |
Updates dependency and plugin versions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+106
to
+108
| public CompletableFuture<ChatResponse> chatAsync(ChatRequest chatRequest) { | ||
| return delegate().chatAsync(chatRequest); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dependencies and plugins to their latest stable releases:
langchain4j-bom1.16.3 → 1.22.0jedis7.5.2 → 8.0.2model-provider2.0.1 → 2.1.0mockito-junit-jupiter5.23.0 → 5.24.0archunit-junit51.5.0 → 1.5.1rest-redis0.1.4 → 0.1.5langchain4j 1.22 adds async methods to
ChatModel;LazyChatModelnow overrides them as well, as required by the ArchUnit rule.mvn clean verifypasses locally (130 tests).🤖 Generated with Claude Code